Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #29 - Auto-register the kedro-mlflow hooks #111

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Nov 2, 2020

Description

Fix #29 - Auto register the 2 hooks (MLlfowPipelineHook and MLlfowNodeHook) for kedro>=0.16.4

Development notes

  • modify setup.py to auto register the hooks
  • Unpin requiremetns to enable kedro>=0.16.5 (which should have been done in FIX #62 - Migrate to 0.16.5 #94 )
  • Change the readme (+ remove non user facing changes)

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • [X Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes -> not done yet, I will add a test to check it works.

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei marked this pull request as draft November 2, 2020 22:36
@Galileo-Galilei Galileo-Galilei changed the title WIP: FIX #29 - Auto-register the kedro-mlflow hooks FIX #29 - Auto-register the kedro-mlflow hooks Nov 2, 2020
@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #111 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          634       634           
=========================================
  Hits           634       634           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adb5ef...773b9f4. Read the comment docs.

@Galileo-Galilei Galileo-Galilei force-pushed the feature/auto-registration branch from 773b9f4 to 69f96a2 Compare November 3, 2020 20:02
@Galileo-Galilei Galileo-Galilei force-pushed the feature/auto-registration branch from 69f96a2 to 4d666ce Compare November 3, 2020 20:09
@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review November 3, 2020 20:09
@Galileo-Galilei Galileo-Galilei merged commit cb43f93 into develop Nov 3, 2020
@Galileo-Galilei Galileo-Galilei deleted the feature/auto-registration branch November 3, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auto-registration for plugin hooks
2 participants