Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Drop lower and upper bounds on python version, and upgrade to python 3.9 (#603) #604

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Oct 23, 2024

Description

Development notes

  • Upgrade python version in test to lower_bound=3.9 and upper_bound=3.12
  • Migrate from pytest-lazy-fixture to pytest-lazy-fixtures in all tests and requirements
  • Upgrade to pytest 8.0.0
  • Fix typo in changelog

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (669fbf1) to head (e5472d0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          29       29           
  Lines        1038     1038           
=======================================
  Hits         1037     1037           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review October 23, 2024 20:10
@Galileo-Galilei Galileo-Galilei merged commit 44a1138 into master Oct 23, 2024
16 of 17 checks passed
@Galileo-Galilei Galileo-Galilei deleted the cleanup branch October 23, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants