Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #83 - Check input_name when set in PipelineML #84

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

Galileo-Galilei
Copy link
Owner

Description

FIX #83 - Check input_name when set in PipelineML

Development notes

  • Decorate input_name with @property
  • Ensure 100% test coverage for pipeline_ml

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • N/A Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei Galileo-Galilei self-assigned this Oct 10, 2020
@Galileo-Galilei Galileo-Galilei added the enhancement New feature or request label Oct 10, 2020
@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #84 into develop will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
+ Coverage    96.71%   96.83%   +0.11%     
===========================================
  Files           32       32              
  Lines         1187     1199      +12     
===========================================
+ Hits          1148     1161      +13     
+ Misses          39       38       -1     
Impacted Files Coverage Δ
kedro_mlflow/pipeline/pipeline_ml.py 100.00% <100.00%> (+1.47%) ⬆️
tests/pipeline/test_pipeline_ml.py 91.13% <100.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98b2e0...8d5ab38. Read the comment docs.

@Galileo-Galilei Galileo-Galilei merged commit 4c0b6a7 into develop Oct 10, 2020
@Galileo-Galilei Galileo-Galilei deleted the feature/pipeline-ml-input-property branch November 13, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the input_name of PipelineML a property
2 participants