Skip to content

Conversation

@Ahim-Gillamore
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nufacturing-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 9:13am

@Ahim-Gillamore Ahim-Gillamore changed the base branch from production to development August 29, 2024 09:29
@gitguardian
Copy link

gitguardian bot commented Aug 29, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13251735 Triggered Generic High Entropy Secret 109c506 .env.testing View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

@flemton flemton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @Ahim-Gillamore, great job correcting Vercel, I approved this PR, but maybe next time you'll need to create the branch from development, get it merged and then open a PR from development to production, cheers 🥂

@Ahim-Gillamore Ahim-Gillamore merged commit 6369067 into development Aug 29, 2024
@Ahim-Gillamore Ahim-Gillamore deleted the NFG-544-Deployment branch August 30, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants