Move cryptol-remote-api to the Cryptol repo
#92
Conversation
It's now in the `cryptol` repository
This fixes `tasty-script-exitcode` to work on systems where Python 3.x is called `python`.
There was a problem hiding this comment.
The deletions all make sense.
The changes to the test code for CI are good to have, but it feels a bit like they're in the "hack until it works" category rather than the "clean thing that works" category. I think that at least an explanatory comment or three could help us make sure we keep them working in the future.
| tasty-hunit ^>= 0.10, | ||
| tasty ^>= 1.2, | ||
| temporary ^>= 1.3 | ||
| build-depends: base >=4.12, |
There was a problem hiding this comment.
The purpose of the ^>= is to add a PVP-based upper bound. This change asserts that we'll work with all the future versions of these packages - is that what we want to be saying?
There was a problem hiding this comment.
I'm not sure that I agree that that's what it means. In my opinion it means that we don't know that we don't work with future versions and don't want to rule them out until we do know that they'll cause problems.
There was a problem hiding this comment.
I was going off the descriptions here: https://cabal.readthedocs.io/en/3.4/cabal-package.html#build-information
But the Platonic form of meaning of the operators and their realization in practice is certainly different, and in practice, we'll have bounds imposed by Cryptol itself anyway.
In conjunction with a related PR, this moves the
cryptol-remote-apipackage from theargorepo to thecryptolrepo.