crucible-llvm: Simplify 'MemoryErrorReason' #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
commented
Nov 6, 2021
There was only one constructor of this type that depended on type parameters 'sym' and 'w', and that was a pointer that is duplicated in the 'MemoryOp' that accompanies each 'MemoryErrorReason'. Also, create a new error datatype instead of using a pretty-printed doc. In addition to making 'MemoryError' more normalized, 'MemoryErrorReason' is now friendlier to programmatic use. In particular, it's orderable.
langston-barrett
force-pushed
the
lb/simplify-mem-error
branch
from
37775d4
to
c721539
Compare
langston-barrett
commented
Nov 8, 2021
Comment on lines
-5
to
9
| [Crux] No implementation or override found for pointer: "_ZN3std2rt19lang_start_internal17h3dc68cf5532522d7E" | ||
| [Crux] No implementation or override found for pointer | ||
| [Crux] The given pointer could not be resolved to a callable function | ||
| [Crux] No implementation or override found for pointer: "_ZN3std2rt19lang_start_internal17h3dc68cf5532522d7E" | ||
| [Crux] No implementation or override found for pointer | ||
| [Crux] Attempting to load callable function with type: i64({ }*, [3 x i64]*, i64, i8**) | ||
| [Crux] Via pointer: Global symbol "_ZN3std2rt19lang_start_internal17h3dc68cf5532522d7E" (1, 0x0:[64]) |
There was a problem hiding this comment.
Note that the function name that is removed from this message appears here at line 9. It was just duplicated between the MemoryOp and the MemoryErrorReason.
robdockins
approved these changes
Nov 8, 2021
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 13, 2021
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one constructor of this type that depended on type
parameters 'sym' and 'w', and that was a pointer that is duplicated in
the 'MemoryOp' that accompanies each 'MemoryErrorReason'.
Also, create a new error datatype instead of using a pretty-printed doc.
In addition to making 'MemoryError' more normalized, 'MemoryErrorReason'
is now friendlier to programmatic use. In particular, it's orderable.