-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ML-DSA: Implement hint pack functions #184
Labels
Comments
marsella
added
CNSA 2.0
version-update
Addresses a new version of an existing spec
labels
Nov 13, 2024
marsella
added a commit
that referenced
this issue
Nov 25, 2024
marsella
added a commit
that referenced
this issue
Nov 25, 2024
marsella
added a commit
that referenced
this issue
Nov 26, 2024
marsella
added a commit
that referenced
this issue
Nov 27, 2024
marsella
added a commit
that referenced
this issue
Nov 27, 2024
marsella
added a commit
that referenced
this issue
Nov 27, 2024
There is a bug that I haven't identified yet; it's triggered at L202 but I cannot figure out why.
marsella
added a commit
that referenced
this issue
Nov 27, 2024
marsella
added a commit
that referenced
this issue
Nov 27, 2024
Changes the type of the index `i` to an integer to avoid overflow when indexing into the larger array.
marsella
added a commit
that referenced
this issue
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
HintBitPack
andHintBitUnpack
functions deal with sparse vectors and require tracking where the non-zero terms in a set of polynomials are. This kind of index-tracking functionality can be hard to express in Cryptol.There's a version in the IPD that uses recursion but doesn't look a lot like the spec. I think it's worth exploring two avenues: try cleaning up the IPD version to see if it can be more closely mapped with some renaming and reordering; or try rewriting from scratch using a different approach (I briefly considered a recursive function that has
Index
as a type parameter andy
as a continually-updated array).The IPD omitted a malformed input check that was added back in the final draft. We need to make sure this gets added as well.
There are failure modes in
HintBitUnpack
so at the least, we should modify the existing implementation to return anOption
that'sNone
in the case of failures.HintBitPack
; feel free to make a draft PR or post in the comments here with ideas to get feedback.HintBitUnpack
to return an optionHintBitUnpack
The text was updated successfully, but these errors were encountered: