Remove uses of coerceSize #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsella
commented
Aug 5, 2024
marsella
force-pushed
the
101-remove-coerceSize
branch
from
9110f3c
to
4769f56
Compare
- I misread `max 1 n - 1` when making the previous change. Removes the `max`s that are obsoleted by the numeric constraint guards I added. - Adds docstrings for properties in `ntt` that I used to debug.
yav
reviewed
Aug 30, 2024
| @@ -115,13 +116,14 @@ shuffle a = | |||
| /** | |||
| * Perform the butterfly operation. | |||
| */ | |||
| butterfly : {n} (fin n, n > 0) => Integer -> [n]Fld -> [n]Fld -> [2 * n]Fld | |||
There was a problem hiding this comment.
Why did we make the type of butterfly less general here (i.e., it seems looks like the function makes sense for any length > 0, rather than just powers of 2)
There was a problem hiding this comment.
Oh gosh, good question. I don't remember what I was thinking here, but probably I was just iterating on trying to understand the implementation and accidentally left this in. I'll change it back, thanks for catching this!
yav
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
This removes all the uses of
coerceSize. It also remove a bunch of trailing whitespace, because my editor does that automatically, and adds a copyright notice.This is on hold for now because as mentioned in the issue, it depends on a nightly-only feature of cryptol.Now ready for review after the release of Cryptol 3.2.0!