Remove old EC / ECDSA implementations #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsella
commented
Aug 21, 2024
Common/EC/README.md
Outdated
| + p384_field.cry | ||
| + ref_ec_mul.cry | ||
| ``` | ||
| This is one of many, many implementations of the NIST prime field curves that have been written in Cryptol over the years. One grandparent of particular interest is a 2011 curve implementation that was used to verify a Java implementation of ECDSA in combination with [SAWScript](https://saw.galois.com/). This implementation no longer lives in this repo, but it can be seen together with the Java code and the SAW scripts used in the full verification toolchain [in the examples directory of the SAWScript repository](https://github.com/GaloisInc/saw-script/tree/master/examples/ecdsa). |
There was a problem hiding this comment.
Two links questions:
- Should I link to the SAWScript website or its github page? I think the website is a bit out of date but it has a good quick answer to "what is saw??"
- Should I pin to a specific commit when pointing to the saw example or is master OK? In particular, do we expect to rearrange the structure of that repo such that this link will break? cc: @sauclovian-g
There was a problem hiding this comment.
Let's link to the github page for now.
There was a problem hiding this comment.
There will almost certainly be a general reorg of the saw-script tree eventually... but I don't see that extending to moving the examples dir, so you're probably safe to point to it on master.
There was a problem hiding this comment.
Thanks! I updated the saw link.
mccleeary-galois
approved these changes
Aug 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113.
Updates the READMEs to give more context on history and point towards other versions of ECDSA and EC living elsewhere. But mostly deletes.