MLKEM FIPS 203 final #131
Merged
MLKEM FIPS 203 final #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change API to XOF to accept a single parameter of exactly 34 bytes. 2. Correct order of parameter to calls to XOF to "rho # j # i" as in FIPS 203 FINAL. Signed-off-by: Rod Chapman <rodchap@amazon.com>
… 203 FINAL Signed-off-by: Rod Chapman <rodchap@amazon.com>
…_Encrypt Signed-off-by: Rod Chapman <rodchap@amazon.com>
marsella
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thank you for updating the code! I confirmed that the KATs run as-is.
This is now out of alignment with the README in this directory which points to the initial draft and corresponding KATs, and the PDF of the IPD. I can pop that change into a separate issue for us to handle internally, but you're also welcome to change the links and delete the PDF.
This was
linked to
issues
Sep 3, 2024
|
I added the two issues that I think this addresses in the sidebar, please remove them if you think they're not fully covered by this PR. |
|
Looks good to me. |
9 tasks
|
I added #135 to follow up on the other issues I noted here. Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the specification of ML-KEM to meet the final FIPS 203 specification, issued by NIST on 13th August 2024.
Updated KATs from https://github.com/post-quantum-cryptography/KAT/tree/main/MLKEM
run fine with these changes.