-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ML-KEM KATs #150
Add ML-KEM KATs #150
Conversation
I would strongly recommend doing just the At this point that'll be kind of a pain to retcon in though and maybe it's not really worthwhile... |
This fixes files to be capitalized, removes an illegal dash, and adjusts things to sit in our newly established directory structure. Note that this does not build because the module names no longer match the file names.
This brings module names into alignment with our standard (capitalized, matches the directory path, etc) and the directory structure in line with our recent changes (`Instantiations/` and `Tests/`)
5118481
to
cbf9ea9
Compare
It didn't take that long to fix, so now the individual commit diffs look good. The overall diff still fails to recognize the rename, but hopefully this will help anyone pawing through the history. |
It will. I just checked and git log --follow works, and it probably didn't before. Also should anyone be merging/rebasing they can now merge stepwise over the renames if they need to, which can avoid all kinds of weird problems. Thanks :-) |
Closes #148
This adds a few easy-to-run tests for ML-KEM that will hopefully make it easier to be confident about all the upcoming changes in the ML-KEM gold standard issues. They are not fast and I only added one for each parameter set, although there are many more in the sourced repo.
In addition to the work listed in the linked issue, this also renames all the modules around here to adhere better to our standards.