Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptol-remote-api dumping SBV debug info #1378

Closed
weaversa opened this issue Jul 5, 2022 · 1 comment · Fixed by #1379
Closed

cryptol-remote-api dumping SBV debug info #1378

weaversa opened this issue Jul 5, 2022 · 1 comment · Fixed by #1379
Labels
remote-api Related to Cryptol's remote API

Comments

@weaversa
Copy link
Collaborator

weaversa commented Jul 5, 2022 •
edited
Loading

During our CI runs, calls that involve SBV are dumping debug lines to the log, such as [ISSUE] (define-fun s832 () (_BitVec 28) (concat s732 s831) -- dumping SMT files and other large things. This is recent, and does not happen when calling solvers via W4. The [ISSUE] line shows up here: https://github.com/LeventErkok/sbv/blob/bbab5b9aa5ef63d393120cca2e93df3b703626a1/Data/SBV/SMT/SMT.hs#L864
We also see other debug commands such as [SEND] and [RECV]. Is there a way to quiet this noisiness?
@RyanGlScott RyanGlScott added the remote-api Related to Cryptol's remote API label Jul 5, 2022
@RyanGlScott
Copy link
Contributor

We haven't changed anything recently involving the way SBV is handled, so I'm not sure why this would only be showing up now. In any case, we are in fact always passing pcVerbose = True in cryptol-remote-api, which can cause SBV to print verbose output. Apropos of nothing, we should probably stick to Cryptol's default of pcVerbose = False for remote API purposes.

RyanGlScott added a commit that referenced this issue Jul 8, 2022
@RyanGlScott
cryptol-remote-api: Don't use verbose SBV settings
3278540 
We should try to match Cryptol's default settings when invoking the remote API,
but the `pcVerbose` value (`True`) didn't match the defaults. Changing this to
`False` should fix #1378. There is a separate question of whether remote API
users should be able to change this default, but for the time being, let's at
least be consistent between Cryptol's settings and the remote API's settings.
@RyanGlScott RyanGlScott mentioned this issue Jul 8, 2022
Merged
RyanGlScott added a commit that referenced this issue Jul 8, 2022
@RyanGlScott
cryptol-remote-api: Don't use verbose SBV settings (#1379)
69f07cc 
We should try to match Cryptol's default settings when invoking the remote API,
but the `pcVerbose` value (`True`) didn't match the defaults. Changing this to
`False` should fix #1378. There is a separate question of whether remote API
users should be able to change this default, but for the time being, let's at
least be consistent between Cryptol's settings and the remote API's settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
remote-api Related to Cryptol's remote API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cryptol-remote-api: Don't use verbose SBV settings GaloisInc/cryptol
2 participants
@RyanGlScott @weaversa