[new module system] Incorrect declaration order after type checking

[yav]

Example:

  x : [8]

submodule G where
  import interface submodule S 
  y = x + 1

submodule F where
  import interface submodule S as A

  submodule P where x = 8
  submodule M = submodule G { submodule P }
  import submodule M
  z = 1 + y
 
submodule Arg where
  x = 5
 
submodule FA = submodule F { submodule Arg }
import submodule FA

This results in:

/* Not recursive */
Main::Arg::x : {a} (Literal 5 a) => a
Main::Arg::x = \{a} (Literal 5 a) -> Cryptol::number 5 a <>

/* Not recursive */
Main::F::A::x : [8]
Main::F::A::x = Main::Arg::x [8] <>

/* Not recursive */
Main::FA::z : [8]
Main::FA::z =
  (Cryptol::+) [8] <> (Cryptol::number 1 [8] <>) Main::FA::M::y

/* Not recursive */
Main::FA::M::y : [8]
Main::FA::M::y =
  (Cryptol::+) [8] <> Main::G::S::x (Cryptol::number 1 [8] <>)

/* Not recursive */
Main::G::S::x : [8]
Main::G::S::x = Main::FA::P::x [8] <>

/* Not recursive */
Main::FA::P::x : {a} (Literal 8 a) => a
Main::FA::P::x = \{a} (Literal 8 a) -> Cryptol::number 8 a <>

Note that Main::FA::M::y is used before it is defined.

[yav]

This is fixed on the module system branch