Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused code for a LetEnabled REPL option #901

Closed
brianhuffman opened this issue Sep 23, 2020 · 0 comments · Fixed by #906
Closed

Unused code for a LetEnabled REPL option #901

brianhuffman opened this issue Sep 23, 2020 · 0 comments · Fixed by #906
Labels
tech-debt For issues that require some internal refactoring.

Comments

@brianhuffman
Copy link
Contributor

The REPL implementation contains some code for enabling/disabling let declarations in user input. This includes the eLetEnabled field of the REPL RW type, and the functions enableLet, disableLet, and getLetEnabled in module Cryptol/REPL/Monad.hs. But apparently most of this is dead code, and the REPL provides no way to disable let expressions. (And why would you want to, anyway?)

Perhaps this LetEnabled code should all be removed.

@brianhuffman brianhuffman added the tech-debt For issues that require some internal refactoring. label Sep 23, 2020
brianhuffman pushed a commit that referenced this issue Sep 23, 2020
brianhuffman pushed a commit that referenced this issue Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt For issues that require some internal refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant