Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse panic #1071

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Fix parse panic #1071

merged 5 commits into from
Feb 17, 2021

Commits on Feb 16, 2021

  1. Add failing tests for issues 962, 1045, and 1050. 

    These are all related to the parsing of explicit type application
forms, and the fixup pass that is supposed to attach them to
function identifiers.
    @robdockins
    robdockins committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    bad2649 View commit details
    Browse the repository at this point in the history

  2. Demote the panic that arises from bare type applications 

    to a kind-checking error.  This at least provides actionable
feedback about where the error occurs.

We should also improve the parser post-processing pass to
handle these situations better, but this at least removes
the panic.
    @robdockins
    robdockins committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    668c135 View commit details
    Browse the repository at this point in the history

  3. Update the parser to deal more robustly with type applications. 

    We now reject situations where the user writes a type application
on a term that is not an identifier, and we correctly unwind
and reapply tuple and field selectors.

Fixes #962
Fixes #1045
Fixes #1050
    @robdockins
    robdockins committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    2a2ec6e View commit details
    Browse the repository at this point in the history

  4. Update tests outputs

    @robdockins
    robdockins committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    5f269dd View commit details
    Browse the repository at this point in the history

  5. More comments to illustrate how projections and type applications 

    are supposed to interact.
    @robdockins
    robdockins committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    6734400 View commit details
    Browse the repository at this point in the history