-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T1169 #1171
Conversation
This is useful for debugging
@@ -1,15 +1,6 @@ | |||
Loading module Cryptol | |||
Loading module Cryptol | |||
Loading module T15 | |||
[warning] at T15.cry:5:13--5:14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about losing these warnings. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered about that too. More generally, I wonder if we should issue a warning when a local name shadows an imported name. This is what the comment on line 166 of Renamer.hs
is about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it probably makes sense to do that, controlled by the warnShadowing
option.
.github/ci.sh
Outdated
@@ -39,7 +39,7 @@ retry() { | |||
|
|||
setup_external_tools() { | |||
is_exe "$BIN" "test-runner" && return | |||
cabal v2-install --install-method=copy --installdir="$BIN" test-lib | |||
cabal v2-install --install-method=copy --installdir="$BIN" test-lib-0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cabal v2-install --install-method=copy --installdir="$BIN" test-lib-0.3 | |
cabal v2-install --install-method=copy --installdir="$BIN" test-lib |
* feat(rpc): safe for python api * refactor: use enum for smt query type * Update cryptol-remote-api/python/cryptol/__init__.py Co-authored-by: Ryan Scott <ryan.gl.scott@gmail.com> * Update cryptol-remote-api/python/cryptol/__init__.py Co-authored-by: Ryan Scott <ryan.gl.scott@gmail.com> Co-authored-by: Ryan Scott <ryan.gl.scott@gmail.com>
This fixes, hopefully, some incorrect behavior of import declarations