T1169 #1171
Merged
T1169 #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for debugging
robdockins
reviewed
Apr 21, 2021
robdockins
reviewed
Apr 21, 2021
robdockins
reviewed
Apr 21, 2021
| @@ -1,15 +1,6 @@ | |||
| Loading module Cryptol | |||
| Loading module Cryptol | |||
| Loading module T15 | |||
| [warning] at T15.cry:5:13--5:14 | |||
There was a problem hiding this comment.
I'm not sure how I feel about losing these warnings. What do you think?
There was a problem hiding this comment.
I wondered about that too. More generally, I wonder if we should issue a warning when a local name shadows an imported name. This is what the comment on line 166 of Renamer.hs is about.
There was a problem hiding this comment.
I feel like it probably makes sense to do that, controlled by the warnShadowing option.
.github/ci.sh
Outdated
| @@ -39,7 +39,7 @@ retry() { | |||
|
|
|||
| setup_external_tools() { | |||
| is_exe "$BIN" "test-runner" && return | |||
| cabal v2-install --install-method=copy --installdir="$BIN" test-lib | |||
| cabal v2-install --install-method=copy --installdir="$BIN" test-lib-0.3 | |||
There was a problem hiding this comment.
Suggested change
| cabal v2-install --install-method=copy --installdir="$BIN" test-lib-0.3 | |
| cabal v2-install --install-method=copy --installdir="$BIN" test-lib |
* feat(rpc): safe for python api * refactor: use enum for smt query type * Update cryptol-remote-api/python/cryptol/__init__.py Co-authored-by: Ryan Scott <ryan.gl.scott@gmail.com> * Update cryptol-remote-api/python/cryptol/__init__.py Co-authored-by: Ryan Scott <ryan.gl.scott@gmail.com> Co-authored-by: Ryan Scott <ryan.gl.scott@gmail.com>
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Apr 27, 2021
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes, hopefully, some incorrect behavior of import declarations