initial newtype support for rpc server #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnwamk
force-pushed
the
wip/rpc/feat/newtype
branch
3 times, most recently
from
02aa4d9
to
8b149a5
Compare
atomb
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
This looks good to me! There probably are bits of it that would be useful on the SAW side, and perhaps we should eventually refactor to make them usable by both servers, but I think getting this working now is more important, and we can do any refactoring in a later PR (or PRs).
pnwamk
force-pushed
the
wip/rpc/feat/newtype
branch
from
52b1721
to
affee13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.