Explicit stride #1227
Merged
Explicit stride #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't yet pipe the new constructs through the typechecker.
Hook them up through the typechecker. However, we still need implementations.
We define `inf /^ n = inf` and `inf %^ n` for finite, positive `n`.
|
Documentation updates are still needed, but I wanted to make sure we are happy with the syntax choices before doing that. |
Minor output changes in the exercises are required.
|
@robdockins the notation makes sense to me. The only improvement I can think of is to clarify in the comment-docs for the "inclusive" constructs (the non |
We need to avoid the new `down` keyword.
yav
requested changes
Jun 30, 2021
|
AFAICT, the remaining failures are not related to this PR. |
|
@yav, @brianhuffman, any additional thoughts about this? |
yav
reviewed
Jul 19, 2021
yav
reviewed
Jul 19, 2021
This was referenced Jul 20, 2021
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jul 21, 2021
Add stub implementations of the new enumeration primitives from GaloisInc/cryptol#1227, and fix up the type of `ecFromTo`, which also changed slightly in that PR.
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jul 28, 2021
Add stub implementations of the new enumeration primitives from GaloisInc/cryptol#1227, and fix up the type of `ecFromTo`, which also changed slightly in that PR.
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jul 29, 2021
Add stub implementations of the new enumeration primitives from GaloisInc/cryptol#1227, and fix up the type of `ecFromTo`, which also changed slightly in that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new syntactic forms for enumerations with explicit stride values (CF #1087).
The currently-implemented syntax steals the identifiers
byanddownas new keywords; we should discuss if this is acceptable, or if new syntax should be designed.