Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix CVC4 and Docker upload issues #1230

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Attempt to fix CVC4 and Docker upload issues #1230

merged 2 commits into from
Jul 8, 2021

Conversation

atomb
Copy link
Contributor

@atomb atomb commented Jul 7, 2021

We will need a better solution to getting CVC4 eventually, but unbreaking the builds, even temporarily, is high priority. And the right solution for CVC4, with the recent transition to CVC5, is somewhat tricky.

I believe the one test failure is an allowed failure and can be ignored for now.

@atomb atomb marked this pull request as ready for review July 7, 2021 20:49
@atomb atomb requested a review from kquick July 7, 2021 20:49
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree: this should re-enable useful build results and we can address CVC updates later.

@atomb atomb merged commit c1a2bfb into master Jul 8, 2021
@atomb atomb deleted the at-build-fix branch July 8, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants