Fix issue 1239 #1254
Merged
Fix issue 1239 #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when indexing into a sequence, there were code paths in both the SBV and What4 backends where an if/then/else tree would be built to compute the value of a symbolic lookup, with one branch for each valid sequence index. They differed, however, in what value they would comute for out-of-bound indices. For SBV, we would compute a `zero` value, whereas for What4 we would raise an error. For What4, this resulted in unfortunate and redundant proof obligations, as we elsewhere add a test for in-bounds contditions to the safety predicate. Moreover, the strategy of returning a `zero` value could panic in some situations, as not every type has a `zero` value anymore (e.g., newtypes). In both cases, we now do the same thing, which is not to have a case of the if/then/else tree for out-of-bounds indices; the final element of the sequence will simply be returned instead. We will only raise an out of bounds error in this code path if the sequence is actually empty. Fixes #1239
This tracks changes to the symbolic indexing primitives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.