Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptol-remote-api: Allow building with aeson-2.0.* #1308

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

RyanGlScott
Copy link
Contributor

This introduces some CPP, unfortunately, but this probably necessary to
continue allowing cryptol-remote-api to be buildable with old versions of
aeson until the ecosystem catches up with aeson-2.0.*.

This introduces some CPP, unfortunately, but this probably necessary to
continue allowing `cryptol-remote-api` to be buildable with old versions of
`aeson` until the ecosystem catches up with `aeson-2.0.*`.
Copy link
Contributor

@pnwamk pnwamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Out of curiosity, why is this an improvement over leaving the upper bound at 2.0 until the ecosystem widely uses @aeson-2.0.0.0@ or later?

@RyanGlScott
Copy link
Contributor Author

Out of curiosity, why is this an improvement over leaving the upper bound at 2.0 until the ecosystem widely uses @aeson-2.0.0.0@ or later?

We could do that, I suppose. Supporting aeson-2.0.* is a prerequisite to being able to build things with GHC 9.2, however, and I'm not sure whether we'll support 9.2 before or after the ecosystem catches up to aeson-2.0.*. If I had to place a bet, I'd bet "before".

@RyanGlScott RyanGlScott merged commit ebb1dd1 into master Nov 30, 2021
@RyanGlScott RyanGlScott deleted the aeson-2.0 branch November 30, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants