Only include bindist-related files in cryptol.msi
#1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would include every file in the current `cryptol` checkout in `cryptol.msi`, which would result in horribly bloated installer files. We now only include those files under the `dist` directory (created by `.github/ci.sh bundle_files`), which curates only those files we want to include in a binary distribution. While I was in town, I modified the conventioned used in `win32/cryptol.wxs` so that we no longer need to reference `dist`, which does not show up in `.tar.gz`-based bindists. Fixes #977.
kquick
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would include every file in the current
cryptolcheckout incryptol.msi, which would result in horribly bloated installer files. We now only include those files under thedistdirectory (created by.github/ci.sh bundle_files), which curates only those files we want to include in a binary distribution.While I was in town, I modified the conventioned used in
win32/cryptol.wxsso that we no longer need to referencedist, which does not show up in.tar.gz-based bindists.Fixes #977.