AES-NI version of SuiteB module using FFI #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yav
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Looks good to me. It might also be nice to have a version that goes as fast as possible (i.e., changes the API to avoid the byte swapping, and also doesn't check if the instructions are supportd (i.e., only works if you have the hardware). I'll make a separate thicket for that though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module
SuiteB_FFIwhich uses AES-NI hardware instructions on x86_64 when possible, and falls back to the Cryptol/Haskell primitive implementations in the builtinSuiteBmodule otherwise.Closes #1398.