Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for ModuleNameMismatch error and add regression test. #1419

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Improve error message for ModuleNameMismatch error and add regression test. #1419

merged 2 commits into from
Aug 29, 2022

Conversation

taimoorzaeem
Copy link
Contributor

Fixes issue #1253.

@RyanGlScott
Copy link
Contributor

Thanks, @taimoorzaeem.

The CI is failing on Windows because the error message is printing out a relative path, which displays as [error] ./issue1253b.cry:1:8--1:11: on macOS and Linux but [error] .\issue1253b.cry:1:8--1:11: on Windows (note the backslash instead of the forward slash). You should be able to resolve this issue by checking in a separate tests/issues/issue1253.icry.stdout.mingw32 file that uses a backslash instead of a forward slash, which the test suite will use only on Windows.

@RyanGlScott RyanGlScott merged commit 91c8227 into GaloisInc:master Aug 29, 2022
@taimoorzaeem taimoorzaeem deleted the issue1253 branch August 30, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants