Backtick imports #1481
Merged
Backtick imports #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed separately. XXX: The order in which parameters should be added is very unclear.
The actual backtick syntactic sugar still needs to be
implemented, at the moment we use
module M = F {_}
The plan is that
import `F
is syntactic sugar for
module M = F {_}
import M
This is also fixes some longstanding tech debt where we were reusing the name for the type of a newtype and the constructor of a newtype
These don't really check anything
The reason for this is that we don't have anywhere to place the generated module---we could put it outside the interface, but that wont' work if the instantiation used an imported module, and it would be inconsistent with how other such imports work. Instead, users need to make the substantiation manually outside the interface. Fixes #1485
This is how the system used to work. This commit also restores some of the old tests.
Now the names take into account the qualifiers of the parameters. Thus if a module has a value parameter `I::x` the record of parameters will have a field `I'x`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.