Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtick imports #1481

Merged
merged 21 commits into from
Dec 22, 2022
Merged

Backtick imports #1481

merged 21 commits into from
Dec 22, 2022

Conversation

yav
Copy link
Member

@yav yav commented Dec 12, 2022

No description provided.

…ed separately.

XXX: The order in which parameters should be added is very
unclear.
The actual backtick syntactic sugar still needs to be
implemented, at the moment we use

module M = F {_}

The plan is that
import `F
is syntactic sugar for
module M = F {_}
import M
This is also fixes some longstanding tech debt where we were reusing the
name for the type of a newtype and the constructor of a newtype
These don't really check anything
The reason for this is that we don't have anywhere to place the generated
module---we could put it outside the interface, but that wont' work if
the instantiation used an imported module, and it would be inconsistent
with how other such imports work.   Instead, users need to make the
substantiation manually outside the interface.

Fixes #1485
@yav yav marked this pull request as ready for review December 20, 2022 23:54
@yav yav merged commit 98dc7f5 into functors-merge Dec 22, 2022
@RyanGlScott RyanGlScott deleted the T1480 branch March 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant