Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building with sbv-10.* #1523

Merged
merged 1 commit into from
May 26, 2023
Merged

Support building with sbv-10.* #1523

merged 1 commit into from
May 26, 2023

Conversation

RyanGlScott
Copy link
Contributor

sbv-10.0 brings in two changes to the SBV internals that affect Cryptol.

  1. sbv-10.0 removes the generateSMTBenchmark function in favor of two separate generateSMTBenchmarkSat and generateSMTBenchmarkProof functions.
  2. sbv-10.0 removes the allSatHasPrefixExistentials field of AllSatResult.

We now use the appropriate CPP to make Cryptol compile before and after these changes.

Fixes #1513.

`sbv-10.0` brings in two changes to the SBV internals that affect Cryptol.

1. `sbv-10.0` removes the `generateSMTBenchmark` function in favor of two
   separate `generateSMTBenchmarkSat` and `generateSMTBenchmarkProof` functions.
2. `sbv-10.0` removes the `allSatHasPrefixExistentials` field of `AllSatResult`.

We now use the appropriate CPP to make Cryptol compile before and after these
changes.

Fixes #1513.
@RyanGlScott RyanGlScott requested a review from yav May 26, 2023 17:47
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know this code, but the change look reasonable to me.

@RyanGlScott RyanGlScott merged commit 5778f6f into master May 26, 2023
@RyanGlScott RyanGlScott deleted the T1513 branch May 26, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sbv-10.*
2 participants