Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 3.0.0 release #1531

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Prepare for 3.0.0 release #1531

merged 8 commits into from
Jun 26, 2023

Conversation

RyanGlScott
Copy link
Contributor

No description provided.

@RyanGlScott RyanGlScott requested review from yav and kquick June 22, 2023 17:54
Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the online doc references I noted. Also, don't forget to set the dates in the changelogs...

CHANGES.md Outdated Show resolved Hide resolved
@RyanGlScott
Copy link
Contributor Author

Also, don't forget to set the dates in the changelogs...

To be clear, you want to add a date next to the "3.0.0" section in the changelog? Or are you envisioning more than that? (You did use plural "dates", after all.)

@RyanGlScott RyanGlScott temporarily deployed to github-pages June 23, 2023 17:36 — with GitHub Actions Inactive
@kquick
Copy link
Member

kquick commented Jun 23, 2023

Also, don't forget to set the dates in the changelogs...

To be clear, you want to add a date next to the "3.0.0" section in the changelog? Or are you envisioning more than that? (You did use plural "dates", after all.)

Nope, just that. I used plural because there are two changelogs and thus two dates to update, but I agree that was imprecise.

@RyanGlScott RyanGlScott temporarily deployed to github-pages June 26, 2023 13:00 — with GitHub Actions Inactive
@RyanGlScott RyanGlScott merged commit 78fcd4f into master Jun 26, 2023
@RyanGlScott RyanGlScott deleted the at-release-3.0-prep branch June 26, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants