Sanitize strings in to_cryptol_str in quoting.py
#1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
reviewed
Jul 5, 2023
RyanGlScott
approved these changes
Jul 5, 2023
yav
requested changes
Jul 5, 2023
yav
reviewed
Jul 6, 2023
|
@m-yac Would you be willing to update |
|
@weaversa I can do that, let me check internally about version numbering and I'll let you know when an update to PyPI is pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
to_cryptol_strto correctly sanitize strings. For example, ifs = '" \ \n', thencry_f('{s}')now correctly gives'"\\" \\\\ \\n"'instead of the unescaped'"" \\ \n"'.