Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize strings in to_cryptol_str in quoting.py #1541

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Jul 5, 2023

This PR updates to_cryptol_str to correctly sanitize strings. For example, if s = '" \ \n', then cry_f('{s}') now correctly gives '"\\" \\\\ \\n"' instead of the unescaped '"" \\ \n"'.

@m-yac m-yac self-assigned this Jul 5, 2023
@m-yac m-yac temporarily deployed to github-pages July 5, 2023 19:50 — with GitHub Actions Inactive
@m-yac m-yac temporarily deployed to github-pages July 5, 2023 20:22 — with GitHub Actions Inactive
cryptol-remote-api/python/cryptol/quoting.py Outdated Show resolved Hide resolved
@m-yac m-yac temporarily deployed to github-pages July 6, 2023 14:13 — with GitHub Actions Inactive
@m-yac m-yac temporarily deployed to github-pages July 6, 2023 14:22 — with GitHub Actions Inactive
Copy link
Collaborator

@weaversa weaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me!

@m-yac m-yac temporarily deployed to github-pages July 6, 2023 17:07 — with GitHub Actions Inactive
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m-yac m-yac merged commit 68e48dd into master Jul 6, 2023
@m-yac m-yac deleted the sanitize-strs-quoting branch July 6, 2023 17:58
@weaversa
Copy link
Collaborator

weaversa commented Jul 6, 2023

@m-yac Would you be willing to update https://pypi.org/project/cryptol/?

@m-yac
Copy link
Contributor Author

m-yac commented Jul 6, 2023

@weaversa I can do that, let me check internally about version numbering and I'll let you know when an update to PyPI is pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants