Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply apSubst to Type field of EPropGuards in TVars instance for Expr #1570

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

qsctr
Copy link
Contributor

@qsctr qsctr commented Aug 30, 2023

Fixes #1569.

Not really sure how to test this since the Type field is not really used within Cryptol itself. GaloisInc/saw-script#1923 does seem to be fixed by this change though.

@qsctr qsctr self-assigned this Aug 30, 2023
@qsctr qsctr temporarily deployed to github-pages August 30, 2023 00:29 — with GitHub Actions Inactive
@qsctr qsctr marked this pull request as ready for review August 30, 2023 00:47
@qsctr qsctr requested a review from yav August 30, 2023 00:47
@qsctr qsctr temporarily deployed to github-pages August 31, 2023 22:10 — with GitHub Actions Inactive
@qsctr qsctr merged commit 8f5586e into master Sep 1, 2023
43 checks passed
@qsctr qsctr deleted the T1569 branch September 1, 2023 05:47
bboston7 pushed a commit to GaloisInc/saw-script that referenced this pull request Sep 1, 2023
Closes #1923

This change updates the cryptol submodule to pull in the fix for
constraint guards with types dependent on module parameters.

See GaloisInc/cryptol#1569 for the relevant
cryptol issue and GaloisInc/cryptol#1570 for the
fix.
bboston7 pushed a commit to GaloisInc/saw-script that referenced this pull request Sep 1, 2023
Closes #1923

This change updates the cryptol submodule to pull in the fix for
constraint guards with types dependent on module parameters.

See GaloisInc/cryptol#1569 for the relevant
cryptol issue and GaloisInc/cryptol#1570 for the
fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect EPropGuards case in TVars instance for Expr
2 participants