Respect VWord/VSeq invariants in parmap implementation
#1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Previously, `parmap` could incorrectly return a `VWord` when the element type was not `Bit`, and it could also return a `VSeq` when the element type was `Bit`. This changes the implementation of `parmap` to use the `mkSeq` smart constructor, which properly chooses what sort of `GenValue` to return depending on the element type. Fixes #1578.
RyanGlScott
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
parmapcould incorrectly return aVWordwhen the element type was notBit, and it could also return aVSeqwhen the element type wasBit. This changes the implementation ofparmapto use themkSeqsmart constructor, which properly chooses what sort ofGenValueto return depending on the element type.Fixes #1578.