Always show foreign dependencies in file-deps, and whether or not they exist on disk
#1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qsctr
added
command-line-repl
qsctr
changed the title
:file-deps, and whether or not they exist on diskfile-deps, and whether or not they exist on disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
:file-depsREPL command and thefile_depsremote API call always return the path of a foreign dependency (shared library) when it should exist (i.e. if there areforeigndeclarations in the module), instead of only if it currently exists. Furthermore, for each foreign dependency return a pair of a string and a boolean, representing the file path and whether or not the file actually currently exists. (In Python the pair is represented as a length-2 list.)This addresses one part of #1574.