Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do renaming on types the same way we do renaming on expressions. #669

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Do renaming on types the same way we do renaming on expressions. #669

merged 2 commits into from
Dec 13, 2019

Conversation

brianhuffman
Copy link
Contributor

This does fixity resolution for types during renaming, with proper error reporting when conflicting fixities are encountered.

Fixes issue #614.

yav
yav approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@yav yav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this code in a while, but the changes seem reasonable to me.

There's a small issue related to the pretty printing of infix operators with default fixity, but I'll make a separate ticket for it.

@brianhuffman
Copy link
Contributor Author

All the CI builds are failing, but it's not my fault: They all complain about a missing yices binary.

@brianhuffman brianhuffman merged commit ce6f1ed into master Dec 13, 2019
@brianhuffman brianhuffman mentioned this pull request Dec 14, 2019
Closed
@brianhuffman brianhuffman deleted the issue614 branch September 9, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yav yav yav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhuffman @yav