-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
primality constraint #882
Merged
Merged
primality constraint #882
Commits on Sep 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b5bdd0f - Browse repository at this point
Copy the full SHA b5bdd0fView commit details -
Implement the Field operations on
Z p
in the concrete simulatorand the What4 symbolic simulator. We use the EGCD algorithm to compute inverses for concrete values. For symbolic values, we posit a multiplicitive inverse via a defining equation. To get this to work, we needed to fix a bug in the equation definition code for What4; it was asserting definitions with the wrong polarity for "prove" calls.
Configuration menu - View commit details
-
Copy full SHA for 74cc36c - Browse repository at this point
Copy the full SHA 74cc36cView commit details -
This involves adding the ability to assert definitional relations, and porting the What4 method for modular inverse.
Configuration menu - View commit details
-
Copy full SHA for 1a2a6bb - Browse repository at this point
Copy the full SHA 1a2a6bbView commit details -
Rely on
integer-gmp
primitives for primality tests andmodular inverse computations instead of using the arithmoi and semiring packages.
Configuration menu - View commit details
-
Copy full SHA for a1cf62e - Browse repository at this point
Copy the full SHA a1cf62eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9822d5f - Browse repository at this point
Copy the full SHA 9822d5fView commit details -
Add regression test for the primality testing constraint
and finite field inverse computations.
Configuration menu - View commit details
-
Copy full SHA for da2e2c5 - Browse repository at this point
Copy the full SHA da2e2c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d2e2b9 - Browse repository at this point
Copy the full SHA 2d2e2b9View commit details
Commits on Sep 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6b9a9f1 - Browse repository at this point
Copy the full SHA 6b9a9f1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.