-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test disassembly of .text sections of sample binaries #12
Conversation
Similar tests for the other disassemblers are based on this code: https://github.com/travitch/dismantle/blob/master/dismantle-tablegen/src/Dismantle/Testing.hs. It uses objdump as an oracle and makes sure that we can roundtrip every instruction that objdump knows about. |
f31647c
to
f0afc20
Compare
@kquick suggested that we use |
f0afc20
to
141fd0c
Compare
@kquick I think we'll need an update to the Hydra configuration for this branch to work. If you point me in the right direction, I'm happy to give it a shot. |
NTS: Kevin says that for this to move forward, we should allow an environment variable to specify the locations of the additional test binaries. |
141fd0c
to
a93bf63
Compare
a93bf63
to
50b2f97
Compare
I've updated this with the environment variable configuration, and there's a WIP PR to the Fryingpan config files that will let us test it: https://gitlab-int.galois.com/binary-analysis/nix/-/merge_requests/5 |
We've merged the configuration changes, so by Monday we should have green checks from Fryingpan. Thanks to @kquick for helping me get Fryingpan configured! |
Build is passing on S2N, Kyber, and
|
Some tests for disassembly of some small binaries. Having a test suite like this is nice because
sample-binaries
, which can benefit multiple projects across Galoistests/data
, increment the expected number of tests, and test that Flexdis86 can disassemble it.