Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fuzz testing CI on PR approval. #255

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Run fuzz testing CI on PR approval. #255

merged 1 commit into from
Sep 27, 2023

Conversation

kquick
Copy link
Member

@kquick kquick commented Sep 26, 2023

These were actually sometimes failing, but they were being run on a cron cycle (nightly at 3AM) so notifications were only sent to the last person to modify the cron line (Aaron Tomb, whose github account is disabled... maybe because of this :-).

Additionally, this library is relatively stable (recent activity notwithstanding), so running these on a nightly basis is frivolous. This changes them to run when a PR has been approved, ensuring master remains stable, but not inflicting the additional CI delay on every push.

@kquick kquick requested a review from RyanGlScott September 26, 2023 22:47
@kquick
Copy link
Member Author

kquick commented Sep 27, 2023

It worked! Fuzz tests were run on approval.

@kquick kquick merged commit a99eb34 into master Sep 27, 2023
@kquick kquick deleted the dgb_1695768249-0 branch September 27, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants