Parse constant cmp operand IDs using absolute encoding #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is unused and, as noted in #266 (comment), is almost certainly incorrect.
As noted in #266 (comment), the operand IDs in constant expressions use an absolute encoding. This means that parsing constant `icmp` expressions with `getConstantFwdRefAdjustedId` (which assumes a relative encoding) is incorrect. All forms of constant expressions besides constant `icmp` expressions use `forwardRef` (which assumes an absolute encoding) to parse their value operands, so constant `icmp` expressions are the odd one out. This patch fixes the parsing of constant `icmp` expression operands by (1) removing the `getConstantFwdRefAdjustedId` function, and (2) switching to using `forwardRef`. Fixes #266.
langston-barrett
approved these changes
Jan 30, 2024
kquick
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #266 (comment), the operand IDs in constant expressions use an absolute encoding. This means that parsing constant
icmpexpressions withgetConstantFwdRefAdjustedId(which assumes a relative encoding) is incorrect. All forms of constant expressions besides constanticmpexpressions useforwardRef(which assumes an absolute encoding) to parse their value operands, so constanticmpexpressions are the odd one out.This patch fixes the parsing of constant
icmpexpression operands by (1) removing thegetConstantFwdRefAdjustedIdfunction, and (2) switching to usingforwardRef.Fixes #266.