Sync DebugInfoEnumerator's definition with LLVM 12
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes two changes to `DebugInfoEnumerator` to reflect its current definition as of LLVM 12: * `DIEnumerator` now has an `isUnsigned` field as of https://reviews.llvm.org/D42734 (LLVM 7). * `DIEnumerator` is capable of representing arbitrary-precision integers as of https://reviews.llvm.org/D62475 (LLVM 12). As a consequence, I changed the `Int64` field of `DebugInfoEnumerator` to an `Integer`.
RyanGlScott
added a commit
to GaloisInc/llvm-pretty-bc-parser
that referenced
this pull request
Sep 9, 2021
The relevant LLVM bitcode parser code is here: https://github.com/llvm/llvm-project/blob/1bebc31c617d1a0773f1d561f02dd17c5e83b23b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp#L1386-L1408 This bumps the llvm-pretty submodule to include GaloisInc/llvm-pretty#84. TODO: This hasn't yet been merged—update the submodule when it is.
elliottt
approved these changes
Sep 13, 2021
RyanGlScott
added a commit
to GaloisInc/llvm-pretty-bc-parser
that referenced
this pull request
Sep 13, 2021
The relevant LLVM bitcode parser code is here: https://github.com/llvm/llvm-project/blob/1bebc31c617d1a0773f1d561f02dd17c5e83b23b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp#L1386-L1408 This bumps the llvm-pretty submodule to include GaloisInc/llvm-pretty#84. Fixes #163.
RyanGlScott
added a commit
to GaloisInc/llvm-pretty-bc-parser
that referenced
this pull request
Sep 13, 2021
The relevant LLVM bitcode parser code is here: https://github.com/llvm/llvm-project/blob/1bebc31c617d1a0773f1d561f02dd17c5e83b23b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp#L1386-L1408 This bumps the llvm-pretty submodule to include GaloisInc/llvm-pretty#84. Fixes #163.
RyanGlScott
added a commit
to GaloisInc/llvm-pretty-bc-parser
that referenced
this pull request
Sep 14, 2021
The relevant LLVM bitcode parser code is here: https://github.com/llvm/llvm-project/blob/1bebc31c617d1a0773f1d561f02dd17c5e83b23b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp#L1386-L1408 This bumps the llvm-pretty submodule to include GaloisInc/llvm-pretty#84. Fixes #163.
RyanGlScott
added a commit
to GaloisInc/llvm-pretty-bc-parser
that referenced
this pull request
Sep 14, 2021
The relevant LLVM bitcode parser code is here: https://github.com/llvm/llvm-project/blob/1bebc31c617d1a0773f1d561f02dd17c5e83b23b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp#L1386-L1408 This bumps the llvm-pretty submodule to include GaloisInc/llvm-pretty#84. Fixes #163.
RyanGlScott
added a commit
to GaloisInc/crucible
that referenced
this pull request
Sep 16, 2021
This bumps the `llvm-pretty` and `llvm-pretty-bc-parser` submodules to include the following changes: * GaloisInc/llvm-pretty#85 and GaloisInc/llvm-pretty-bc-parser#166, which adds support for the `freeze` instruction introduced in LLVM 12. * GaloisInc/llvm-pretty#84 and GaloisInc/llvm-pretty-bc-parser#164, which allows parsing `DIEnumerator`s on LLVM 12 or later. * GaloisInc/llvm-pretty#83 and GaloisInc/llvm-pretty-bc-parser#162, which allows parsing `DICompositeType`s on LLVM 12 or later. * GaloisInc/llvm-pretty-bc-parser#161, which allows parsing `fcmp` instructions with fast-math flags. The `freeze` instruction will require some changes in `crucible-llvm` to accommodate, but I will do that in a subsequent commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes to
DebugInfoEnumeratorto reflect its current definition as of LLVM 12:DIEnumeratornow has anisUnsignedfield as of https://reviews.llvm.org/D42734 (LLVM 7).DIEnumeratoris capable of representing arbitrary-precision integers as of https://reviews.llvm.org/D62475 (LLVM 12). As a consequence, I changed theInt64field ofDebugInfoEnumeratorto anInteger.