Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for addition of badBehaviorMap implicit for LLVM annotations. #157

Merged
merged 5 commits into from
Aug 11, 2020
Merged

Update for addition of badBehaviorMap implicit for LLVM annotations. #157

merged 5 commits into from
Aug 11, 2020

Conversation

kquick
Copy link
Member

@kquick kquick commented Aug 9, 2020

@chameco chameco mentioned this pull request Aug 11, 2020
Merged
@robdockins
Copy link
Contributor

It seems like this subsumes #153, is that correct?

@kquick
Copy link
Member Author

kquick commented Aug 11, 2020

It seems like this subsumes #153, is that correct?

Oops, I had not seen 153 before starting this effort. Sorry for the duplication, but this one is probably a superset of the changes and is ready to be merged.

@kquick kquick requested a review from robdockins August 11, 2020 17:49
robdockins
robdockins approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right to me

@kquick kquick merged commit 4713bc9 into master Aug 11, 2020
@kquick kquick deleted the llvm_annotations_upd branch August 11, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdockins robdockins robdockins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kquick @robdockins