Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macaw-riscv-symbolic: Indexes for registers #456

Merged
merged 1 commit into from
Dec 10, 2024
Merged

macaw-riscv-symbolic: Indexes for registers #456

merged 1 commit into from
Dec 10, 2024

Conversation

RyanGlScott
Copy link
Contributor

@RyanGlScott RyanGlScott commented Dec 5, 2024 •
edited
Loading

Like #445, but for RISC-V.

langston-barrett
langston-barrett approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the compile-time concern!

macaw-riscv-symbolic/src/Data/Macaw/RISCV/Symbolic/Regs.hs Outdated Show resolved Hide resolved
@RyanGlScott RyanGlScott force-pushed the T444-riscv-symbolic-regs branch from 3a41f57 to 3da4bc8 Compare December 10, 2024 17:01
@RyanGlScott RyanGlScott marked this pull request as ready for review December 10, 2024 17:02
@RyanGlScott
Copy link
Contributor Author

While I'm not entirely happy with the compile times in Data.Macaw.RISCV.Symbolic.Regs (which currently takes just over 10 seconds to compile), none of my attempts at rewriting it proved very successful. As such, I'll just accept the cost.

@RyanGlScott RyanGlScott merged commit 76b1191 into master Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langston-barrett langston-barrett langston-barrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanGlScott @langston-barrett