-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
saw-rustc
doesn't work with const
or static
values
#55
Labels
Comments
The " |
29 tasks
RyanGlScott
added a commit
that referenced
this issue
Sep 9, 2023
…roring `crux-rustc` makes it an error to annotate non-functions with `#[crux::test]` attributes. `saw-rustc` effectivelly annotates _everything_ with that attribute, but we don't want to error when the annotation is applied to a non-function, as typical Rust code will have more things (e.g., statics) than just functions. We now make `saw-rustc` skip non-functions (thereby not marking them as roots) instead of erroring. Fixes #55.
RyanGlScott
added a commit
that referenced
this issue
Sep 11, 2023
…roring `crux-rustc` makes it an error to annotate non-functions with `#[crux::test]` attributes. `saw-rustc` effectivelly annotates _everything_ with that attribute, but we don't want to error when the annotation is applied to a non-function, as typical Rust code will have more things (e.g., statics) than just functions. We now make `saw-rustc` skip non-functions (thereby not marking them as roots) instead of erroring. Fixes #55.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given that this is the third issue of this sort that we've opened (after #53 and #47), I wonder if we should rethink our approach to what
saw-rustc
disallows.The text was updated successfully, but these errors were encountered: