Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Update cryptol #153

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Update cryptol #153

merged 3 commits into from
Jan 28, 2021

Conversation

brianhuffman
Copy link
Contributor

Adapt the cryptol-saw-core package to a few recent changes to cryptol:

brianhuffman pushed a commit to GaloisInc/saw-script that referenced this pull request Jan 28, 2021
Update cryptol and saw-core submodules.
c6f6f41 
TODO: update this commit once GaloisInc/saw-core#153 is merged
to point at the correct submodule hash.
robdockins
robdockins approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Only thing to consider is if we should be enabling calls stacks (the first argument to ModuleInput. They're sort of expensive to track, but we're also not really using the evaluator here, so maybe it doesn't matter much.

@brianhuffman
Copy link
Contributor Author

I decided to set that field to True just because that is the default value within Cryptol, so I thought that would be the safe choice. You're right that we really are not using the cryptol evaluator within SAW, so it shouldn't make much difference either way.

@brianhuffman brianhuffman merged commit 26a21f3 into master Jan 28, 2021
@brianhuffman brianhuffman deleted the update-cryptol branch January 29, 2021 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robdockins robdockins robdockins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhuffman @robdockins