Skip to content

Commit

Permalink
Use only Z3 4.8.12 on Ubuntu 20.04
Browse files Browse the repository at this point in the history
Older Z3 and Ubuntu versions are causing trouble.
  • Loading branch information
Aaron Tomb committed Sep 14, 2021
1 parent c8127e1 commit 4d1c15d
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ install_z3() {
is_exe "$BIN" "z3" && return

case "$RUNNER_OS" in
Linux) file="ubuntu-18.04.zip" ;;
Linux) file="glibc-2.31.zip" ;;
macOS) file="osx-10.15.7.zip" ;;
Windows) file="win.zip" ;;
esac
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ env:
# ./saw/Dockerfile
# ./saw-remote-api/Dockerfile
# ./s2nTests/docker/saw.dockerfile
Z3_VERSION: "4.8.10"
Z3_VERSION: "4.8.12"
CVC4_VERSION: "4.1.8"
YICES_VERSION: "2.6.2"

Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
path: dist/bin
name: ${{ runner.os }}-bins

- if: "matrix.os == 'ubuntu-18.04'"
- if: "matrix.os == 'ubuntu-20.04'"
uses: actions/upload-artifact@v2
with:
name: "saw-${{ runner.os }}-${{ matrix.ghc }}"
Expand Down Expand Up @@ -225,11 +225,11 @@ jobs:
matrix:
include:
- test: saw-remote-api/scripts/run_rpc_tests.sh
os: ubuntu-18.04
os: ubuntu-20.04
- test: saw-remote-api/scripts/run_rpc_tests.sh
os: macos-latest
- test: saw-remote-api/scripts/check_docs.sh
os: ubuntu-18.04
os: ubuntu-20.04
steps:
- uses: actions/checkout@v2
with:
Expand Down Expand Up @@ -277,7 +277,7 @@ jobs:
fail-fast: false
matrix:
suite: ${{ fromJson(needs.build.outputs.cabal-test-suites-json) }}
os: [ubuntu-18.04]
os: [ubuntu-20.04]
continue-on-error: [false]
include:
- suite: integration_tests
Expand Down Expand Up @@ -446,7 +446,7 @@ jobs:
name: "Test s2n proofs"
timeout-minutes: 60
needs: build
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
Expand Down
4 changes: 2 additions & 2 deletions s2nTests/docker/s2n.dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:18.04
FROM ubuntu:20.04

RUN apt-get update -y -q && \
apt-get install -y software-properties-common && \
Expand All @@ -25,4 +25,4 @@ RUN mkdir -p /saw-script && \

COPY scripts/s2n-entrypoint.sh /entrypoint.sh
ENTRYPOINT [ "/entrypoint.sh" ]
CMD [ "/bin/bash" ]
CMD [ "/bin/bash" ]
4 changes: 2 additions & 2 deletions saw-remote-api/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ USER user
WORKDIR /solvers
RUN mkdir -p rootfs/usr/local/bin

# Get Z3 4.8.10 from GitHub
RUN curl -L https://github.com/Z3Prover/z3/releases/download/z3-4.8.10/z3-4.8.10-x64-ubuntu-18.04.zip --output z3.zip
# Get Z3 4.8.12 from GitHub
RUN curl -L https://github.com/Z3Prover/z3/releases/download/z3-4.8.12/z3-4.8.12-x64-glibc-2.31.zip --output z3.zip
RUN unzip z3.zip
RUN mv z3-*/bin/z3 rootfs/usr/local/bin

Expand Down
4 changes: 2 additions & 2 deletions saw/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ USER user
WORKDIR /solvers
RUN mkdir -p rootfs/usr/local/bin

# Get Z3 4.8.10 from GitHub
RUN curl -L https://github.com/Z3Prover/z3/releases/download/z3-4.8.10/z3-4.8.10-x64-ubuntu-18.04.zip --output z3.zip
# Get Z3 4.8.12 from GitHub
RUN curl -L https://github.com/Z3Prover/z3/releases/download/z3-4.8.12/z3-4.8.12-x64-glibc-2.31.zip --output z3.zip
RUN unzip z3.zip
RUN mv z3-*/bin/z3 rootfs/usr/local/bin

Expand Down

0 comments on commit 4d1c15d

Please sign in to comment.