Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to debugIntrinsics option in crucible #1388

Closed
RyanGlScott opened this issue Jul 21, 2021 · 1 comment · Fixed by #1424
Closed

Adapt to debugIntrinsics option in crucible #1388

RyanGlScott opened this issue Jul 21, 2021 · 1 comment · Fixed by #1424
Labels
PR: submodule bump Pull requests that include a submodule bump subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm

Comments

@RyanGlScott
Copy link
Contributor

GaloisInc/crucible#782 adds a new debugIntrinsics option, which controls whether llvm.dbg statements should be translated or not, to various functions in crucible-llvm:Lang.Crucible.LLVM.Translation, which will affect SAW. While tools like Crux can safely set debugIntrinsics to False, as they do not make use of llvm.dbg intrinsics, SAW does make use of these intrinsics (see #1385). As a result, we'll need to be a bit careful when updating SAW to use GaloisInc/crucible#782. We'll likely want to add a SAW option for configuring the value of debugIntrinsics, since there are programs (such as the one identified in GaloisInc/crucible#778) that currently will not work in Crucible with the debug intrinsics present.

@RyanGlScott RyanGlScott added subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm PR: submodule bump Pull requests that include a submodule bump labels Jul 21, 2021
@RyanGlScott
Copy link
Contributor Author

GaloisInc/crucible#782 has landed, but I'll wait until after #1403 (which updates the crucible submodule up until the point of GaloisInc/crucible#782's commits) lands before making the necessary changes SAW-side.

RyanGlScott added a commit that referenced this issue Aug 20, 2021
Fixes #1388. Bumps the `crucible` submodule.
RyanGlScott added a commit that referenced this issue Aug 25, 2021
Fixes #1388. Bumps the `crucible` submodule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: submodule bump Pull requests that include a submodule bump subsystem: crucible-llvm Issues related to LLVM bitcode verification with crucible-llvm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant