Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saw-remote-api: Unintentional uses of undefined #1390

Closed
RyanGlScott opened this issue Jul 21, 2021 · 0 comments · Fixed by #1392
Closed

saw-remote-api: Unintentional uses of undefined #1390

RyanGlScott opened this issue Jul 21, 2021 · 0 comments · Fixed by #1392
Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: bug Issues reporting bugs or unexpected/unwanted behavior

Comments

@RyanGlScott
Copy link
Contributor

I recently spotted the following code in saw-remote-api:

saw-script/saw-remote-api/src/SAWServer/SetOption.hs

Lines 36 to 39 in d2b99ca

EnableSMTArrayMemoryModel enabled -> undefined
updateRW rw { rwSMTArrayMemoryModel = enabled }
EnableWhat4HashConsing enabled -> undefined
updateRW rw { rwWhat4HashConsing = enabled }

Notice the uses of the undefined function. I haven't tested, but I'm fairly certain that these lines of code would error at runtime if invoked. Most likely, these uses of undefined are placeholders that were never removed.
@RyanGlScott RyanGlScott added type: bug Issues reporting bugs or unexpected/unwanted behavior subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings labels Jul 21, 2021
RyanGlScott added a commit that referenced this issue Jul 22, 2021
@RyanGlScott
saw-remote-api: Remove uses of undefined
054647c 
These are most likely placeholder values that were accidentally left in the
code. Let's remove them.

Fixes #1390.
@RyanGlScott RyanGlScott mentioned this issue Jul 22, 2021
Merged
RyanGlScott added a commit that referenced this issue Jul 22, 2021
@RyanGlScott
saw-remote-api: Remove uses of undefined (#1392)
78bbe4e 
These are most likely placeholder values that were accidentally left in the
code. Let's remove them.

Fixes #1390.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
subsystem: saw-remote-api Issues related to the SAW server and its RPC bindings type: bug Issues reporting bugs or unexpected/unwanted behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

saw-remote-api: Remove uses of undefined GaloisInc/saw-script
1 participant
@RyanGlScott