Switch jvm-parser package to use prettyprinter library. #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhuffman
force-pushed
the
jvm-parser-prettyprinter
branch
2 times, most recently
from
e3269d0
to
09a12f9
Compare
|
It looks like the failures are caused by type errors in the jvm-verifier package. This is a bit annoying because (as of #1005) saw-script actually doesn't even use that code anymore! I suppose we could wait until jvm-verifier is removed completely (#1056), but it probably wouldn't be too much work to just patch jvm-verifier, so maybe I'll do that. |
|
Actually, it looks like patching jvm-verifier is a bigger job than I thought. I should probably just wait until we can remove it completely. So I'll just convert this PR to a draft until we fix #1056. |
brianhuffman
force-pushed
the
jvm-parser-prettyprinter
branch
from
09a12f9
to
4f8c28d
Compare
brianhuffman
added
the
PR: ready to merge
atomb
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes GaloisInc/jvm-parser#8, which should be merged first.
Fixes #951.