Avoid concatenating Text values in termToPat.
#1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
approved these changes
May 4, 2021
|
This is going to interact somewhat with #1298. I'm not sure what is the best order for them to land. |
|
I was holding off on merging this because I wasn't sure that this was the best solution to the problem, so I was thinking about making further changes. Go ahead and merge #1298 first. |
Fixes #1263. We now use `identBaseName` instead of `identText` in the `termToPat` definition. While `identText` concatenates the module name and base name, `identBaseName` just returns the base name directly. Using only the base name means that there is a chance of name collisions between constants that differ only by module name. However, term nets are only used as an approximate filter prior to term matching; it is not a problem if a few extra hits are returned from time to time. Ultimately it might be better to replace the use of `Text` in the term net `Atom` constructor with a more specialized key type; for example with `ExtCns` names we could use the `VarIndex` for matching. However, this would require modifying the term net library.
brianhuffman
force-pushed
the
issue1263
branch
from
481c618
to
1c74cf4
Compare
brianhuffman
added
the
PR: ready to merge
|
later it says |
|
I guess that was a transient failure, since it worked after a restart without any changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1263.
We now use
identBaseNameinstead ofidentTextin thetermToPatdefinition. While
identTextconcatenates the module name and basename,
identBaseNamejust returns the base name directly.Using only the base name means that there is a chance of name collisions
between constants that differ only by module name. However, term nets
are only used as an approximate filter prior to term matching; it is
not a problem if a few extra hits are returned from time to time.
Ultimately it might be better to replace the use of
Textin the termnet
Atomconstructor with a more specialized key type; for examplewith
ExtCnsnames we could use theVarIndexfor matching. However,this would require modifying the term net library.