Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize rewrite rules using intEq and intModEq relations. #1297

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

brianhuffman
Copy link
Contributor

This is a band-aid pending a proper solution for #1261.

@RyanGlScott
Copy link
Contributor

This seems plausible, but is there a test case that can be distilled down to exercise these new code paths?

@brianhuffman
Copy link
Contributor Author

Sure, I can add something to the test suite.

Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, looks good to me, pending a test case.

@robdockins
Copy link
Contributor

It would be nice to get this band-aid merged...

@brianhuffman
Copy link
Contributor Author

Yes, it would be good to merge this; I guess it just kind of fell off my radar. It looks like it's all ready except for adding a regression test.

This is a band-aid pending a proper solution for #1261.
@brianhuffman brianhuffman added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Aug 26, 2021
@brianhuffman brianhuffman merged commit 98dc581 into master Aug 26, 2021
@brianhuffman brianhuffman deleted the ruleOfProp-intEq branch August 26, 2021 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants