Heapster bugfixes for tcCFG #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 9, 2021 14:11
…ucible BlockIDs they were created from
…t widening iteration, to allow everything to quiesce
eddywestbrook
added
the
subsystem: heapster
glguy
approved these changes
Aug 10, 2021
| buildBlockIDMap (viewAssign -> AssignExtend asgn _) = | ||
| Ctx.extend (fmapFC extendBlockIDTrans $ buildBlockIDMap asgn) | ||
| (BlockIDTrans Member_Base) | ||
| buildBlockIDMap blks = |
There was a problem hiding this comment.
Not critical, but since this only uses the size of the incoming assignment, it might be nice to take the Size directly.
There was a problem hiding this comment.
Ooh, yes, good suggestion!
eddywestbrook
added
the
PR: ready to merge
glguy
approved these changes
Aug 10, 2021
|
I am merging this manually because I have run the CI locally and confirmed that everything works correctly, and because the github CI does not seem to be running...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two bugs in the top-level type-checker for CFGs,
tcCFG:deleteEntryCalleeswas keeping the call sites it was supposed to deletetcCFGwas limited to 5 iterations that allow widening before we have to stop, to avoid an infinite loopI also changed the
Showmethod forTypedBlockIDandTypedEntryIDso that the block numbers are printed the same as the corresponding standard Crucible block numbers.