Updated type inference to not re-type-check the bodies and types of globals #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and primitives when it encounters them; also updated globalOpenTerm to not re-type-check the bodies and types of globals when it uses them
brianhuffman
approved these changes
Aug 20, 2021
eddywestbrook
added
the
PR: ready to merge
brianhuffman
force-pushed
the
bugfix-global-infer-performance
branch
from
6e872ac
to
0aacaf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
typeInferforTermF Termperformed amapM typeInferComplete ton terms that were not lambdas or pis. The issue here is that thistypeInferCompletethen traverses everyTermthat is a subterm oft, including the bodies ofConstantdefinitions and the types of primitives and constants. This change fixes that issue.This change also fixes a similar issue in the definition of
globalOpenTerm, which now computes the type of a global usingscTypeOfGlobalrather than calling into the type inference engine for its type.