Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heapster] Changes pre 9/3/21 demo #1448

Merged
merged 5 commits into from
Sep 3, 2021
Merged

[Heapster] Changes pre 9/3/21 demo #1448

merged 5 commits into from
Sep 3, 2021

Conversation

m-yac
Copy link
Contributor

@m-yac m-yac commented Sep 3, 2021

This PR makes two changes:

  • Adds an iterative version of is_elem to iter_linked_list and proves the same things about it that we do for the recursive version
  • Adds a README to the heapster-saw directory explaining how to use Heapster and giving some detail about the examples in the heapster-saw/examples directory.

These changes are directly targeting anyone who might be interested in Heapster and looking to learn more after our Heapster talk tomorrow.

@eddywestbrook I didn't include any notes in the README on the rust examples because I'm not familiar with them, feel free to send me some descriptions and I will add them.

Copy link
Contributor

@eddywestbrook eddywestbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent walkthrough, thanks Matt! I suggested a few small tweaks to the document, but otherwise it's great! We should definitely mention it in the talk today.

heapster-saw/README.md Outdated Show resolved Hide resolved
heapster-saw/README.md Outdated Show resolved Hide resolved
heapster-saw/README.md Outdated Show resolved Hide resolved
heapster-saw/README.md Outdated Show resolved Hide resolved
heapster-saw/README.md Outdated Show resolved Hide resolved
heapster-saw/README.md Outdated Show resolved Hide resolved
@m-yac m-yac added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Sep 3, 2021
@eddywestbrook eddywestbrook added the subsystem: heapster Issues specifically related to memory verification using Heapster label Sep 3, 2021
@m-yac m-yac merged commit d6fe840 into master Sep 3, 2021
@m-yac m-yac deleted the heapster-iter-is-elem branch September 3, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run subsystem: heapster Issues specifically related to memory verification using Heapster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants